Reuse --bonsai-historical-block-limit for limit trie logs feature#6445
Merged
siladu merged 5 commits intobesu-eth:mainfrom Jan 23, 2024
Merged
Reuse --bonsai-historical-block-limit for limit trie logs feature#6445siladu merged 5 commits intobesu-eth:mainfrom
siladu merged 5 commits intobesu-eth:mainfrom
Conversation
…etention-threshold Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
|
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
21 tasks
jframe
approved these changes
Jan 23, 2024
Merged
siladu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #5390
$BESU --Xbonsai-limit-trie-logs-enabled=truewill use the default value of--bonsai-historical-block-limit=512$BESU --Xbonsai-limit-trie-logs-enabled=true --bonsai-historical-block-limit=511throws error as must be >= 512$BESU --Xbonsai-limit-trie-logs-enabled=false --bonsai-historical-block-limit=511does not throw error as this is allowed until limit-trie-logs-enabled.This implementation avoids a breaking change for anyone that has a node with --bonsai-historical-block-limit already set to < 512 (could be noone?)
However, we should be aware that if
--Xbonsai-limit-trie-logs-enabledever becomes default then this breaking change will come back again