Skip to content

Don't start the BFT mining coordinator when it is created, just enable it #6675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthew1001 merged 4 commits into from
Mar 12, 2024
Merged

Don't start the BFT mining coordinator when it is created, just enable it #6675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1e64e7
Don't start a BFT mining coordinator when it is created, just enable it
matthew1001 Mar 4, 2024
d9ec79f
Update change log
matthew1001 Mar 11, 2024
3b86e93
Merge branch 'main' into no-bft-start
matthew1001 Mar 12, 2024
7a25329
Merge branch 'main' into no-bft-start
matthew1001 Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@

### Bug fixes
- Make block transaction selection max time aware of PoA transitions [#6676](https://github.com/hyperledger/besu/pull/6676)
- Don't enable the BFT mining coordinator when running sub commands such as `blocks export` [#6675](https://github.com/hyperledger/besu/pull/6675)

### Download Links

Expand Down
4 changes: 0 additions & 4 deletions besu/src/main/java/org/hyperledger/besu/controller/IbftBesuControllerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,7 @@ protected MiningCoordinator createMiningCoordinator(
.getBlockPeriodSeconds()));

if (syncState.isInitialSyncPhaseDone()) {
LOG.info("Starting IBFT mining coordinator");
ibftMiningCoordinator.enable();
ibftMiningCoordinator.start();
} else {
LOG.info("IBFT mining coordinator not starting while initial sync in progress");
}

syncState.subscribeCompletionReached(
Expand Down
4 changes: 0 additions & 4 deletions besu/src/main/java/org/hyperledger/besu/controller/QbftBesuControllerBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,7 @@ protected MiningCoordinator createMiningCoordinator(
.getBlockPeriodSeconds()));

if (syncState.isInitialSyncPhaseDone()) {
LOG.info("Starting QBFT mining coordinator");
miningCoordinator.enable();
miningCoordinator.start();
} else {
LOG.info("QBFT mining coordinator not starting while initial sync in progress");
}

syncState.subscribeCompletionReached(
Expand Down