removed tests for pki qbft and add deprecation notice#6979
removed tests for pki qbft and add deprecation notice#6979macfarla merged 3 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
|
Think this failure is because we are getting timing info from the test report from previous run? And that name no longer exists - https://github.com/hyperledger/besu/actions/runs/8794044759/job/24132855802?pr=6979
|
|
Can also remove some test infrastructure for PKI in AT DSL in BesuNode, ProcessBesuNodeRunner and ThreadBesuNodeRunner |
There was a problem hiding this comment.
There are some more tests and resource that could be deleted now if you want. The acceptance-tests pki-certs in the test resources.
Also the CMS tests CmsCreationAndValidationTest and CmsTestKeystores which are part of the PKI feature in the pki module. Though they don't seem be causing in trouble so maybe they can stay till the big delete.
Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com>
* removed tests for pki qbft and add deprecation notice Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> * remove more PKI and CMS creation utils from tests Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> --------- Signed-off-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Justin Florentine <justin+github@florentine.us>
PR description
Remove tests for PKI-backed QBFT feature
Add deprecation notice
Fixed Issue(s)
fixes #6932
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests