Skip to content

EIP-2935: Serve historical block hashes from state#7080

Merged
shemnon merged 13 commits intobesu-eth:mainfrom
shemnon:eip-2935-danno
May 12, 2024
Merged

EIP-2935: Serve historical block hashes from state#7080
shemnon merged 13 commits intobesu-eth:mainfrom
shemnon:eip-2935-danno

Conversation

@shemnon
Copy link
Copy Markdown
Contributor

@shemnon shemnon commented May 9, 2024

PR description

Refactor the BlockHashOperation
to move hash lookup into the
ProtocolSpec, and combine logic with beacn root storage.

Signed-off-by: Danno Ferrin danno@numisight.com
Author: Gabriel-Trintinalia gabriel.trintinalia@consensys.net
Co-authored-by: Danno Ferrin danno@numisight.com

Fixed Issue(s)

Fixes #6531

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

Refactor the BlockHashOperation
to move hash lookup into the
ProtocolSpec, and combine logic with beacn root storage.

Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon mentioned this pull request May 9, 2024
3 tasks
shemnon added 4 commits May 9, 2024 08:25
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon marked this pull request as ready for review May 9, 2024 17:57
Signed-off-by: Danno Ferrin <danno@numisight.com>
Copy link
Copy Markdown
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shemnon and others added 5 commits May 12, 2024 01:06
…net/blockhash/PragueBlockHashProcessor.java

Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
…net/blockhash/PragueBlockHashProcessor.java

Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Danno Ferrin <danno.ferrin@shemnon.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon enabled auto-merge (squash) May 12, 2024 07:12
Signed-off-by: Danno Ferrin <danno@numisight.com>
@shemnon shemnon merged commit 821daf1 into besu-eth:main May 12, 2024
jflo pushed a commit to jflo/besu that referenced this pull request May 28, 2024
* EIP-2935: Serve historical block hashes from state

Refactor the BlockHashOperation to move hash lookup into the
ProtocolSpec, and combine logic with beacon root storage.

Update t8n test to use block hash list in new format

Signed-off-by: Danno Ferrin <danno@numisight.com>
Author: Gabriel-Trintinalia gabriel.trintinalia@consensys.net
Co-authored-by: Danno Ferrin danno@numisight.com
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
matthew1001 pushed a commit to kaleido-io/besu that referenced this pull request Jun 7, 2024
* EIP-2935: Serve historical block hashes from state

Refactor the BlockHashOperation to move hash lookup into the
ProtocolSpec, and combine logic with beacon root storage.

Update t8n test to use block hash list in new format

Signed-off-by: Danno Ferrin <danno@numisight.com>
Author: Gabriel-Trintinalia gabriel.trintinalia@consensys.net
Co-authored-by: Danno Ferrin danno@numisight.com
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
jflo pushed a commit to jflo/besu that referenced this pull request Jun 10, 2024
* EIP-2935: Serve historical block hashes from state

Refactor the BlockHashOperation to move hash lookup into the
ProtocolSpec, and combine logic with beacon root storage.

Update t8n test to use block hash list in new format

Signed-off-by: Danno Ferrin <danno@numisight.com>
Author: Gabriel-Trintinalia gabriel.trintinalia@consensys.net
Co-authored-by: Danno Ferrin danno@numisight.com
Co-authored-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net>
Signed-off-by: Justin Florentine <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EIP-2935: Serve historical block hashes from state

2 participants