Include currently active EVM version in admin_nodeInfo response#7127
Merged
macfarla merged 3 commits intobesu-eth:mainfrom Jun 4, 2024
Merged
Include currently active EVM version in admin_nodeInfo response#7127macfarla merged 3 commits intobesu-eth:mainfrom
admin_nodeInfo response#7127macfarla merged 3 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
admin_nodeInfo response
macfarla
reviewed
May 29, 2024
Contributor
macfarla
left a comment
There was a problem hiding this comment.
needs a changelog entry and there's a stray println, otherwise LGTM
| final Map<String, Object> response = new HashMap<>(); | ||
| final Map<String, Integer> ports = new HashMap<>(); | ||
|
|
||
| System.out.println("MRW: Returning node info"); |
Contributor
Author
There was a problem hiding this comment.
Bah, thanks, will remove now and add the changelog entry.
Signed-off-by: Matthew Whitehead <matthew1001@gmail.com>
macfarla
approved these changes
Jun 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Adds a new field
activeForkto the response body ofadmin_nodeInfoJSON/RPC requests.The JSON/RPC call already returns the fork configuration but that requires the caller to make multiple calls and compare chain heights and/or timestamps to infer the currently active fork. The new field makes it possible to determine accurately in a single call.
The value is whatever
getName()returns for the activeProtocolSpec. This means it is sentence cased (upper-case first letter) but a caller would be expected to use a case-insensitive string compare so I'm not inclined to upper or lower case the string.Example output with the
shanghaifork EVM enabled:I've tested the call before and after a fork to check that the value of
activeForkchanges as soon as the new fork is enabled.Fixed Issue(s)
Fixes #7064