EIP 7702 by daniellehrner · Pull Request #7237 · besu-eth/besu

daniellehrner · 2024-06-18T14:07:25Z

PR description

Fixed Issue(s)

fixes #7205

Thanks for sending a pull request! Have you done the following?

Checked out our contribution guidelines?
Considered documentation and added the doc-change-required label to this PR if updates are required.
Considered the changelog and included an update if required.
For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

unit tests: ./gradlew build
acceptance tests: ./gradlew acceptanceTest
integration tests: ./gradlew integrationTest
reference tests: ./gradlew ethereum:referenceTests:referenceTests

garyschulte · 2024-06-21T19:11:27Z

evm/src/main/java/org/hyperledger/besu/evm/worldstate/AbstractWorldUpdater.java

+  @Override
+  public void addCodeToEOA(final Address address, final Bytes code) {
+    if (temporaryEOACode.containsKey(address)) {
+      return;


what happens if there are multiple 7702 transactions in a block for a single address? should we be doing a codeHash check here? or a nonce check?

garyschulte · 2024-06-21T19:16:43Z

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SetCodeTransactionProcessor.java

+                          return;
+                        }
+
+                        worldUpdater.addCodeToEOA(


should we check the nonce before we add code to eoa? i.e. why set code if the nonce is already invalid

jflo

Suggest some refactoring, which will also correct some invalid tests.

jflo · 2024-07-01T16:20:54Z

...st/java/org/hyperledger/besu/tests/acceptance/ethereum/SetCodeTransactionAcceptanceTest.java

+    // The transaction sponsor balance should be greater than 170000 ETH. We don't do an exact
+    // balance check to avoid
+    // having to calculate the exact amount of gas used.
+    assertThat(transactionSponsorBalance).isGreaterThan(new BigInteger("170000000000000000000000"));


why not also assert that rugee now has zero balance?

I think this can be resolved, it is currently on line 111

jflo · 2024-07-01T16:46:18Z

...ore/src/main/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionDecoder.java

+    final long noncesSize = input.nextSize();
+
+    input.enterList();
+    for (int i = 0; i < noncesSize; i++) {


This will fail under fuzzing, when someone sends a list of nonces of length > 1, suggest throwing a decode exception of some sort should that arise. See above point about treating the nonce as an Optional in SetCodeAuthorization but wrapping it with a list only upon encoding/decoding.

jflo · 2024-07-01T16:51:14Z

datatypes/src/main/java/org/hyperledger/besu/datatypes/SetCodeAuthorization.java

+ * @param nonces the list of nonces
+ * @param signature the signature of the EOA account which will be used to set the code
+ */
+public record SetCodeAuthorization(


This domain object describes the nonce as a list, however it is really an Optional of a single value. The fact that we use a List to represent that is an implementation detail of how the RLP is encoded, and should only be necessary in the Encoders/Decoders.

jflo · 2024-07-01T16:55:29Z

...ore/src/main/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionEncoder.java

+    rlpOutput.writeBigIntegerScalar(payload.chainId());
+    rlpOutput.writeBytes(payload.address().copy());
+    rlpOutput.startList();
+    payload.nonces().forEach(rlpOutput::writeLongScalar);


This should never run more than once, and if we make the changes suggested above, we can just do an optional check instead of running the risk that there is more than one.

jflo · 2024-07-01T17:52:25Z

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SetCodeTransactionProcessor.java

+                        if (!chainId.equals(BigInteger.ZERO)
+                            && !payload.chainId().equals(BigInteger.ZERO)
+                            && !chainId.equals(payload.chainId())) {
+                          ;


Empty statement in body of conditional?

jflo · 2024-07-01T17:54:27Z

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SetCodeTransactionProcessor.java

+
+                        if (payload.nonces().size() == 1
+                            && !payload.nonces().getFirst().equals(accountNonce)) {
+                          return;


I think this warrants a logging statement at DEBUG.

jflo · 2024-07-01T18:20:36Z

...src/test/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionDecoderTest.java

+class SetCodeTransactionDecoderTest {
+
+  @Test
+  void shouldDecodeInnerPayloadWithNonce() {


Could be used to implement the missing TODOs above.

jflo · 2024-07-01T18:22:50Z

...src/test/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionDecoderTest.java

+  }
+
+  @Test
+  void shouldDecodeInnerPayloadWithMultipleNonces() {


Invalid test per EIP-7702:

When the list length is zero, consider the authorization nonce to be null. When the list length is one, consider the single integer value to be the provided nonce authorization. Other lengths and value types in this optional are invalid and the transaction as a whole should be considered malformed.

jflo · 2024-07-01T18:28:47Z

...src/test/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionEncoderTest.java

+  }
+
+  @Test
+  void shouldEncodeSingleSetCodeWithMultipleNonces() {


Same as above, invalid test.

jflo · 2024-07-10T14:52:38Z

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetTransactionProcessor.java

            Optional.of(transaction.getVersionedHashes().get().stream().toList()));
+      } else if (transaction.setCodeTransactionPayloads().isPresent()) {
+        setCodeTransactionProcessor.addContractToAuthority(worldUpdaterService, transaction);
+        addressList.addAll(worldUpdaterService.getAuthorities());


Suggest renaming this emptyAccounts, had to trace this back to the declaration and luckily it was documented there.

jflo · 2024-07-10T14:57:22Z

...um/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/SetCodeTransactionProcessor.java

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class SetCodeTransactionProcessor {


Suggest renaming. Perhaps AuthorityProcessor or something, this does not process the transaction, but rather prepares it for processing elsewhere.

jflo · 2024-07-10T18:47:28Z

evm/src/main/java/org/hyperledger/besu/evm/account/AuthorizedCodeAccount.java

+import org.apache.tuweni.bytes.Bytes32;
+import org.apache.tuweni.units.bigints.UInt256;
+
+/** Wraps another account that has authorized code to be loaded into it. */


Suggested change

/** Wraps another account that has authorized code to be loaded into it. */

/** Wraps an EOA account and includes authorized code to be run on behalf of it. */

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Container verification step in release process automated with the container verify GitHub workflow. New workflow is triggered at the end of the release workflow which will check the release container images starts successfully. Verification test only checks container starts and reach the Ethereum main loop Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Fix some reasons for chain download halts when syncing Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net> Signed-off-by: Stefan Pingel <16143240+pinges@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Check and test for the unused container rule, and only returncontract targets can have truncated data rule. Also test the other subcontainer rules in unit tests. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…ting accounts as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…only available in the prague hard fork Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…yet exist Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…rty (besu-eth#7222) * Add build version option to prefix git hash with custom version property * Refactor to make appending the git hash a boolean property. Include a commented-out example of how to use the properties in the gradle file Signed-off-by: Matthew Whitehead <matthew1001@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…esu-eth#7221) Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Ties <71668189+TiesD@users.noreply.github.com> Co-authored-by: Matt Nelson <85905982+non-fungible-nelson@users.noreply.github.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* Add option for LUKSO network Signed-off-by: Wolmin <lamonos123@gmail.com> * Add tests for LUKSO Signed-off-by: Wolmin <lamonos123@gmail.com> * Apply spotless Signed-off-by: Wolmin <lamonos123@gmail.com> * Add changelog entry Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix duplicate func Signed-off-by: Wolmin <lamonos123@gmail.com> * Fix changelog Signed-off-by: Wolmin <lamonos123@gmail.com> * Add bootnodes to genesis Signed-off-by: Wolmin <lamonos123@gmail.com> --------- Signed-off-by: Wolmin <lamonos123@gmail.com> Signed-off-by: Wolmin <44748271+Wolmin@users.noreply.github.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…u-eth#7245) Make the max code size and max initcode size a part of the EVM configuration. As part of the change we need to move the tasks CodeFactory once handled as a static class and move it into the EVM. This has a nice follow on effect that we don't need to pass in max EOF versions or max code sizes anymore. Signed-off-by: Danno Ferrin <danno@numisight.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

* fix the synchronizer usage Signed-off-by: Leni <leniram159@gmail.com> * fix Identifier usage Signed-off-by: Leni <leniram159@gmail.com> --------- Signed-off-by: Leni <leniram159@gmail.com> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… the transaction object (besu-eth#7323) * fix: Use Builder for JsonCallParameter * changelog * add additional unit tests * fix: Update builder to withGas to match the json eth_call --------- Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

… isn't set Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

jflo · 2024-07-16T14:45:03Z

datatypes/src/main/java/org/hyperledger/besu/datatypes/SetCodeAuthorization.java

+   *
+   * @return all the nonces
+   */
+  List<Long> nonces();


Shouldn't this be Optional<Long> nonce() instead since only 1 can be in the RLP list?

… nonces Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

garyschulte · 2024-07-16T22:06:41Z

ethereum/core/src/test-support/java/org/hyperledger/besu/ethereum/core/BlockDataGenerator.java

+        // TODO 7702
+      case SET_CODE -> null;


we should clear this TODO if we don't plan to implement this in tests [yet]

garyschulte · 2024-07-16T22:06:50Z

...um/core/src/test-support/java/org/hyperledger/besu/ethereum/core/TransactionTestFixture.java

        }
        break;
+      case SET_CODE:
+        // TODO 7702


same re: TODO

jflo

Still doesn't stop the encoding detail of the List from leaking upward. Happy to open a PR into this branch to better illustrate what I mean.

...ore/src/main/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionEncoder.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/SetCodeAuthorization.java

Signed-off-by: Justin Florentine <justin+github@florentine.us>

garyschulte

Big PR. Still haven't gotten through all of it, so I am posting comments early.

I think we need more checks around boundary cases for authorizations to ensure we (continue to) correctly handle duplicated authorities, multiple nonces in authorizations, etc

...rc/test/java/org/hyperledger/besu/tests/acceptance/ethereum/PragueAcceptanceTestService.java

acceptance-tests/tests/src/test/resources/dev/dev_prague.json

garyschulte · 2024-07-16T22:39:35Z

...st/java/org/hyperledger/besu/tests/acceptance/ethereum/SetCodeTransactionAcceptanceTest.java

+    // The transaction sponsor balance should be greater than 170000 ETH. We don't do an exact
+    // balance check to avoid
+    // having to calculate the exact amount of gas used.
+    assertThat(transactionSponsorBalance).isGreaterThan(new BigInteger("170000000000000000000000"));


I think this can be resolved, it is currently on line 111

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/SetCodeAuthorization.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/Transaction.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/AuthorityProcessor.java

evm/src/main/java/org/hyperledger/besu/evm/worldstate/AbstractWorldUpdater.java

plugs leaky abstraction

…r at the end. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Justin Florentine <justin+github@florentine.us>

…Account Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…/besu into feat/issue-7205/eip-7702v1 Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Signed-off-by: Justin Florentine <justin+github@florentine.us>

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

…/besu into feat/issue-7205/eip-7702v1

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner force-pushed the feat/issue-7205/eip-7702v1 branch from 9e9311c to 5aeb067 Compare June 18, 2024 14:10

garyschulte reviewed Jun 21, 2024

View reviewed changes

daniellehrner marked this pull request as ready for review June 25, 2024 21:24

jflo requested changes Jul 1, 2024

View reviewed changes

jflo requested changes Jul 10, 2024

View reviewed changes

jflo mentioned this pull request Jul 11, 2024

Besu Prague Tracker #6308

Closed

daniellehrner force-pushed the feat/issue-7205/eip-7702v1 branch from 9c610ec to 7ff9983 Compare July 16, 2024 11:56

daniellehrner and others added 23 commits July 16, 2024 14:01

EIP 7702 first draft

619f4a1

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added CHANGELOG.md entry

6420df0

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

bug fixes, added first tests

73bd969

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Remove deprecation message for --Xp2p-peer-lower-bound (besu-eth#7247)

030721d

Signed-off-by: Gabriel-Trintinalia <gabriel.trintinalia@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

less invasive code injection approach

f4e6b76

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added missing java doc & fixed test

2db71af

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

added (currently non-working) acceptance test, some bug fixes in the …

f133219

…transaction validation and tx pool logic Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fix spotless

64f5f73

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

updated acceptance test, still not working, newPayload request seems …

f2c6b48

…to be necessary before final fork choice update Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

use correct world state to inject temporary code, inject code in exis…

59827f9

…ting accounts as well Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

renamed test service to prague, because the engine versions used are …

123ce12

…only available in the prague hard fork Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

fixed acceptance test, some bug fixes if authorized account does not …

1dad4d1

…yet exist Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Handle invalid snap getTrieNode requests with empty paths gracefully (b…

4c4452f

…esu-eth#7221) Signed-off-by: Jason Frame <jason.frame@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Update Docker base image to Ubuntu 24.04 (besu-eth#7251)

96bbfd5

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Fix flaky SECP256R1 test (besu-eth#7249)

f62c0cc

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

usmansaleem and others added 3 commits July 16, 2024 14:01

Stop transaction selection on TX_EVALUATION_TOO_LONG (besu-eth#7330)

283ab8b

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

message frame buider will create AuthorizedCodeService by itsef if it…

4eeb5f0

… isn't set Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner force-pushed the feat/issue-7205/eip-7702v1 branch from 7ff9983 to 4eeb5f0 Compare July 16, 2024 12:02

daniellehrner added 2 commits July 16, 2024 14:05

Merge branch 'main' into feat/issue-7205/eip-7702v1

c63d4fa

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

get correct nonce for authorization

eea2281

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

jflo requested changes Jul 16, 2024

View reviewed changes

daniellehrner requested a review from jflo July 16, 2024 15:25

nonce only returns a vaid nonce, new method nonceList returns all the…

22e6ff6

… nonces Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

garyschulte mentioned this pull request Jul 16, 2024

TEST 7702 PR for greptile review bot garyschulte/besu#4

Closed

garyschulte reviewed Jul 16, 2024

View reviewed changes

jflo requested changes Jul 16, 2024

View reviewed changes

...ore/src/main/java/org/hyperledger/besu/ethereum/core/encoding/SetCodeTransactionEncoder.java Outdated Show resolved Hide resolved

ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/SetCodeAuthorization.java Outdated Show resolved Hide resolved

plugs leaky abstraction

4f32fee

Signed-off-by: Justin Florentine <justin+github@florentine.us>

garyschulte reviewed Jul 17, 2024

View reviewed changes

daniellehrner and others added 3 commits July 17, 2024 16:01

Merge pull request #1 from jflo/optionalNonce

0f7df16

plugs leaky abstraction

some renaming, acceptance tests checks for exact balance of tx sponso…

51c8e87

…r at the end. Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'main' into feat/issue-7205/eip-7702v1

1c77b78

Signed-off-by: Justin Florentine <justin+github@florentine.us>

jflo approved these changes Jul 17, 2024

View reviewed changes

daniellehrner and others added 7 commits July 17, 2024 17:57

inject the 7702 code into DiffBasedWorldStateUpdateAccumulator.create…

6642f4f

…Account Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'main' into feat/issue-7205/eip-7702v1

761ac41

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'feat/issue-7205/eip-7702v1' of github.com:daniellehrner…

e534fc1

…/besu into feat/issue-7205/eip-7702v1 Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

spotless

e6ec88d

Signed-off-by: Justin Florentine <justin+github@florentine.us>

spotless fix, removed todos

8c71d2b

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

Merge branch 'feat/issue-7205/eip-7702v1' of github.com:daniellehrner…

f6bf975

…/besu into feat/issue-7205/eip-7702v1

make AuthorityProcessor & chain id for it optional

299f65f

Signed-off-by: Daniel Lehrner <daniel.lehrner@consensys.net>

daniellehrner enabled auto-merge (squash) July 17, 2024 18:59

daniellehrner merged commit 895c17d into besu-eth:main Jul 17, 2024

daniellehrner deleted the feat/issue-7205/eip-7702v1 branch October 30, 2024 13:43

NickSneo mentioned this pull request Apr 23, 2025

feat: 7702 decoding LFDT-web3j/web3j#2178

Merged

3 tasks

	/** Wraps another account that has authorized code to be loaded into it. */
	/** Wraps an EOA account and includes authorized code to be run on behalf of it. */

Conversation

daniellehrner commented Jun 18, 2024

PR description

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

Locally, you can run these tests to catch failures early:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jflo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jflo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

garyschulte left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

garyschulte left a comment •

edited

Loading