Add metrics for trie log pruner#7352
Merged
siladu merged 2 commits intobesu-eth:mainfrom Jul 18, 2024
Merged
Conversation
Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: Simon Dudley <simon.dudley@consensys.net>
garyschulte
approved these changes
Jul 18, 2024
Contributor
garyschulte
left a comment
garyschulte
left a comment
There was a problem hiding this comment.
implementation LGTM, metric naming feedback, non-blocking
Comment on lines
+80
to
+83
| BesuMetricCategory.PRUNER, "trie_log_pruned_from_queue", "trie log pruned from queue"); | ||
| this.prunedOrphanCounter = | ||
| metricsSystem.createCounter( | ||
| BesuMetricCategory.PRUNER, "trie_log_pruned_orphan", "trie log pruned orphan"); |
Contributor
There was a problem hiding this comment.
these metric names are only meaningful if you already understand the trie log pruning implementation. I would suggest trie_log_pruned_head and trie_log_pruned_forks
even that implies an understanding of canonical chain and forks. but I had to look at the code to figure out what we meant by _orphan and _queue.
yay, naming feedback.
gconnect
pushed a commit
to gconnect/besu
that referenced
this pull request
Aug 26, 2024
--------- Signed-off-by: Simon Dudley <simon.dudley@consensys.net> Signed-off-by: gconnect <agatevureglory@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Add 3 counters, can be referenced in grafana with:
besu_pruner_trie_log_added_to_prune_queue_total
besu_pruner_trie_log_pruned_from_queue_total
besu_pruner_trie_log_pruned_trie_log_pruned_orphan_total
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests