Changes to release workflow#7711
Merged
cdivitotawela merged 4 commits intobesu-eth:mainfrom Oct 3, 2024
Merged
Conversation
- Workflow environment variable changed to RELEASE_VERSION instead of RELEASE_NAME to make it more meaningful - Workflows draft-release and docker-promote previously trigger workflow container-verify. This can result in trigger is successful but actual verification workflow fails. This will not be reflected in the draft-release and docker-promote workflows. Container verify code is embedded in the draft-release and docker-promote workflows to avoid this confusion Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
siladu
approved these changes
Oct 2, 2024
Contributor
siladu
left a comment
siladu
left a comment
There was a problem hiding this comment.
PR looks sound, my comments are beyond what the PR was intended for - up to you if you want to merge this one first.
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
siladu
reviewed
Oct 3, 2024
Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com>
2fehee
added a commit
to 2fehee/besu
that referenced
this pull request
Oct 4, 2024
* Changes to release workflow - Workflow environment variable changed to RELEASE_VERSION instead of RELEASE_NAME to make it more meaningful - Workflows draft-release and docker-promote previously trigger workflow container-verify. This can result in trigger is successful but actual verification workflow fails. This will not be reflected in the draft-release and docker-promote workflows. Container verify code is embedded in the draft-release and docker-promote workflows to avoid this confusion Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> * PR comment improvements Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> * Match the only tags starting with word latest for latest check Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> --------- Signed-off-by: Chaminda Divitotawela <cdivitotawela@gmail.com> Co-authored-by: Simon Dudley <simon.dudley@consensys.net>Signed-off-by: Chulhee lee <leefehee@naver.com>
This was referenced Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Workflow environment variable changed to RELEASE_VERSION instead of RELEASE_NAME to make it more meaningful
Workflows draft-release and docker-promote previously trigger workflow container-verify. This can result in trigger is successful but actual verification workflow fails. This will not be reflected in the draft-release and docker-promote workflows. Container verify code is embedded in the draft-release and docker-promote workflows to avoid this confusion
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests