Add support for chainId in CallParameters#7720
Merged
macfarla merged 2 commits intobesu-eth:mainfrom Oct 4, 2024
Merged
Conversation
0bbfe65 to
c3a39b5
Compare
Contributor
|
I think we should add a testcase to acceptance tests for this not to ever miss this again |
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
c3a39b5 to
6df088d
Compare
Contributor
Author
Added tests that verify that in case the chainId does not match, then an error is returned, then added the chainId in some successful tests. Worth to know that in |
macfarla
approved these changes
Oct 4, 2024
2fehee
added a commit
to 2fehee/besu
that referenced
this pull request
Oct 4, 2024
Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net> Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>Signed-off-by: Chulhee lee <leefehee@naver.com>
This was referenced Oct 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests