Skip to content

60M default target gas limit for hoodi #8705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 6 commits into from
May 27, 2025
Merged

60M default target gas limit for hoodi #8705

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2019b7a
increase default target gas limit for hoodi
macfarla May 27, 2025
803d09a
changelog
macfarla May 27, 2025
7e72a95
Merge branch 'main' into gas-hoodi
macfarla May 27, 2025
efa6fce
test
macfarla May 27, 2025
94f3ea4
Merge branch 'main' of github.com:hyperledger/besu into gas-hoodi
macfarla May 27, 2025
e74d4af
Merge branch 'gas-hoodi' of github.com:macfarla/besu into gas-hoodi
macfarla May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
- `--Xplugin-rocksdb-blob-garbage-collection-age-cutoff`, `--Xplugin-rocksdb-blob-garbage-collection-force-threshold` BlobDB GC config options [#8599](https://github.com/hyperledger/besu/pull/8599)
- Update discovery library to 25.4.0 [#8635](https://github.com/hyperledger/besu/pull/8635)
- Increase default target-gas-limit to 60M for Ephemery [#8622](https://github.com/hyperledger/besu/pull/8622)
- Increase default target-gas-limit to 60M for Hoodi [#8705](https://github.com/hyperledger/besu/pull/8705)
- Estimate gas on pending block by default [#8627](https://github.com/hyperledger/besu/pull/8627)
- Upgrade Gradle to 8.14 and related plugins [#8638](https://github.com/hyperledger/besu/pull/8638)
- Make gas estimation strict by default [#8629](https://github.com/hyperledger/besu/pull/8629)
Expand Down
11 changes: 6 additions & 5 deletions ...ge/src/main/java/org/hyperledger/besu/consensus/merge/blockcreation/MergeCoordinator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,16 @@ public class MergeCoordinator implements MergeMiningCoordinator, BadChainListene

private static final long DEFAULT_TARGET_GAS_LIMIT = 36_000_000L;
// testnets might have higher gas limits than mainnet and are incrementally updated
private static final long DEFAULT_TARGET_GAS_LIMIT_TESTNET = 36_000_000L;
private static final long NEXT_STEP_TARGET_GAS_LIMIT_TESTNET = 60_000_000L;
private static final long DEFAULT_TARGET_GAS_LIMIT_TESTNET = 60_000_000L;
Copy link
Copy Markdown
Contributor

@Gabriel-Trintinalia Gabriel-Trintinalia May 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider moving these values to NetworkName

// next target gas limit TBD
// private static final long NEXT_STEP_TARGET_GAS_LIMIT_TESTNET = 60_000_000L;

private static final Map<BigInteger, Long> TESTNET_CHAIN_IDS =
Map.of(
BigInteger.valueOf(11155111), NEXT_STEP_TARGET_GAS_LIMIT_TESTNET, // Sepolia
BigInteger.valueOf(17000), NEXT_STEP_TARGET_GAS_LIMIT_TESTNET, // Holesky
BigInteger.valueOf(11155111), DEFAULT_TARGET_GAS_LIMIT_TESTNET, // Sepolia
BigInteger.valueOf(17000), DEFAULT_TARGET_GAS_LIMIT_TESTNET, // Holesky
BigInteger.valueOf(560048), DEFAULT_TARGET_GAS_LIMIT_TESTNET, // Hoodi
BigInteger.valueOf(39438135), NEXT_STEP_TARGET_GAS_LIMIT_TESTNET // Ephemery
BigInteger.valueOf(39438135), DEFAULT_TARGET_GAS_LIMIT_TESTNET // Ephemery
);

/** The Mining parameters. */
Expand Down
Loading