Skip to content

Block gas limit is always positive #8736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gabriel-Trintinalia merged 1 commit into from
Jun 4, 2025
Merged

Block gas limit is always positive #8736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions ...um/core/src/main/java/org/hyperledger/besu/ethereum/transaction/TransactionSimulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,17 +521,10 @@ public long calculateSimulationGasCap(
}
} else {
if (rpcGasCap > 0) {
if (blockGasLimit > 0) {
Copy link
Copy Markdown
Contributor Author

@fab-10 fab-10 Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block gas limit is always greater than zero, the zero case was only there because tests were not setting it

LOG.trace(
"No user provided gas limit, setting simulation gas cap to the value of min(rpc-gas-cap,blockGasLimit) {}",
rpcGasCap);
simulationGasCap = Math.min(rpcGasCap, blockGasLimit);
} else {
LOG.trace(
"No user provided gas limit, setting simulation gas cap to the value of rpc-gas-cap {}",
rpcGasCap);
simulationGasCap = rpcGasCap;
}
LOG.trace(
"No user provided gas limit, setting simulation gas cap to the value of min(rpc-gas-cap,blockGasLimit) {}",
rpcGasCap);
simulationGasCap = Math.min(rpcGasCap, blockGasLimit);
} else {
simulationGasCap = blockGasLimit;
LOG.trace(
Expand Down
Loading
Loading