Skip to content

use dummy coinbase in simulation if not defined #9031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
macfarla merged 2 commits into from
Aug 5, 2025
+10 −2
Merged

use dummy coinbase in simulation if not defined #9031

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17c7e61
use dummy coinbase in simulation if not defined
macfarla Aug 4, 2025
b9acf71
Merge branch 'main' of github.com:hyperledger/besu into qbft-pending-…
macfarla Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ethereum/core/src/main/java/org/hyperledger/besu/ethereum/core/BlockHeaderBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,13 @@ public static BlockHeaderBuilder createPending(
final Bytes32 prevRandao = maybePrevRandao.orElse(null);
final Bytes32 parentBeaconBlockRoot = maybeParentBeaconBlockRoot.orElse(null);

// For PoS, coinbase is always configured, but for PoA it is not configured,
// rather generated for each block via MiningBeneficiaryCalculator.
// For simulation, if not configured, we use a dummy address 0x00.
// We don't throw an exception if coinbase is not configured.
return BlockHeaderBuilder.create()
.parentHash(parentHeader.getHash())
.coinbase(miningConfiguration.getCoinbase().orElseThrow())
.coinbase(miningConfiguration.getCoinbase().orElse(Address.ZERO))
.difficulty(difficulty)
.number(newBlockNumber)
.gasLimit(gasLimit)
Expand Down
6 changes: 5 additions & 1 deletion ethereum/core/src/main/java/org/hyperledger/besu/ethereum/transaction/BlockSimulator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,10 @@ protected BlockHeader overrideBlockHeader(
long timestamp = blockOverrides.getTimestamp().orElseThrow();
long blockNumber = blockOverrides.getBlockNumber().orElseThrow();

// For PoS, coinbase is always configured, but for PoA it is not configured,
// rather generated for each block via MiningBeneficiaryCalculator.
// For simulation, if not configured, we use a dummy address 0x00.
// We don't throw an exception if coinbase is not configured.
BlockHeaderBuilder builder =
BlockHeaderBuilder.createDefault()
.parentHash(header.getHash())
Expand All @@ -396,7 +400,7 @@ protected BlockHeader overrideBlockHeader(
.coinbase(
blockOverrides
.getFeeRecipient()
.orElseGet(() -> miningConfiguration.getCoinbase().orElseThrow()))
.orElseGet(() -> miningConfiguration.getCoinbase().orElse(Address.ZERO)))
.difficulty(
blockOverrides.getDifficulty().map(Difficulty::of).orElseGet(header::getDifficulty))
.gasLimit(
Expand Down