Skip to content

chore: downgrade TransitionUtils TTD log to INFO and clarify log message#9280

Merged
macfarla merged 2 commits intobesu-eth:mainfrom
isuniverseok-ua:transition-utils-logs-fix
Oct 10, 2025
Merged

chore: downgrade TransitionUtils TTD log to INFO and clarify log message#9280
macfarla merged 2 commits intobesu-eth:mainfrom
isuniverseok-ua:transition-utils-logs-fix

Conversation

@isuniverseok-ua
Copy link
Copy Markdown
Contributor

@isuniverseok-ua isuniverseok-ua commented Oct 7, 2025

PR description

downgraded the log level to INFO and also re-worded the message as when going from Clique or PoW to PoS, inability to fetch total difficulty is expected.

Fixed Issue(s)

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@isuniverseok-ua isuniverseok-ua marked this pull request as ready for review October 7, 2025 13:37
@isuniverseok-ua isuniverseok-ua marked this pull request as draft October 7, 2025 13:40
@macfarla
Copy link
Copy Markdown
Contributor

macfarla commented Oct 9, 2025

@isuniverseok-ua follow these instructions to fix the DCO check. https://github.com/hyperledger/besu/pull/9280/checks?check_run_id=52151068759

Also add signoff to each following commit to avoid this problem in the future - suggestions here https://lf-hyperledger.atlassian.net/wiki/spaces/BESU/pages/22154245/DCO

Signed-off-by: Arnesh <arneshdadhich0011@gmail.com>
@isuniverseok-ua isuniverseok-ua force-pushed the transition-utils-logs-fix branch from 68a5139 to 70983a8 Compare October 9, 2025 10:02
@isuniverseok-ua isuniverseok-ua marked this pull request as ready for review October 9, 2025 10:03
@macfarla macfarla enabled auto-merge (squash) October 10, 2025 02:55
@macfarla macfarla merged commit a365cbc into besu-eth:main Oct 10, 2025
46 checks passed
jflo pushed a commit to jflo/besu that referenced this pull request Oct 13, 2025
…age (besu-eth#9280)

Signed-off-by: Arnesh <arneshdadhich0011@gmail.com>
Co-authored-by: Arnesh Dadhich <arneshdadhich@Arneshs-MacBook-Pro.local>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
jflo pushed a commit to jflo/besu that referenced this pull request Oct 13, 2025
…age (besu-eth#9280)

Signed-off-by: Arnesh <arneshdadhich0011@gmail.com>
Co-authored-by: Arnesh Dadhich <arneshdadhich@Arneshs-MacBook-Pro.local>
Co-authored-by: Sally MacFarlane <macfarla.github@gmail.com>
Signed-off-by: jflo <justin+github@florentine.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants