feat: Use multistage Docker build for selecting JRE#9392
Merged
usmansaleem merged 8 commits intobesu-eth:mainfrom Nov 11, 2025
Merged
feat: Use multistage Docker build for selecting JRE#9392usmansaleem merged 8 commits intobesu-eth:mainfrom
usmansaleem merged 8 commits intobesu-eth:mainfrom
Conversation
-- Use multistage docker build to select JRE for Besu -- Fix minor issues in Docker build file Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
fab-10
reviewed
Nov 4, 2025
Contributor
fab-10
left a comment
fab-10
left a comment
There was a problem hiding this comment.
LGTM, please add a CHANGELOG stating that we are now using Temurin instead of plain OpenJDK
| "--add-opens", | ||
| "java.base/java.nio=ALL-UNNAMED" | ||
| "java.base/java.nio=ALL-UNNAMED", | ||
| "--enable-native-access=ALL-UNNAMED" |
Contributor
Author
There was a problem hiding this comment.
This is to avoid warning message that JVM 24+ issues when starting Besu because we are using JNA to load native libraries. It seems to be backward compatible (at least no error is raised) with Java 21 as well.
Contributor
Author
There was a problem hiding this comment.
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
fab-10
approved these changes
Nov 5, 2025
Signed-off-by: Usman Saleem <usman@usmans.info>
ahamlat
approved these changes
Nov 7, 2025
Contributor
ahamlat
left a comment
ahamlat
left a comment
There was a problem hiding this comment.
Async Profiler is working as expected 👍
Signed-off-by: Usman Saleem <usman@usmans.info>
Signed-off-by: Usman Saleem <usman@usmans.info>
jflo
pushed a commit
to jflo/besu
that referenced
this pull request
Nov 17, 2025
-- Use multistage docker build to select JRE for Besu -- Fix minor issues in Docker build file Signed-off-by: Usman Saleem <usman@usmans.info>
pinges
pushed a commit
to pinges/besu
that referenced
this pull request
Dec 15, 2025
-- Use multistage docker build to select JRE for Besu -- Fix minor issues in Docker build file Signed-off-by: Usman Saleem <usman@usmans.info> Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
feat: Use multistage Docker build for selecting JRE
-- Use multistage docker build to select JRE for Besu
-- Fix minor issues in Docker build file
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests