Use SyncTransactionReceipt in SNAP sync by Matilda-Clerke · Pull Request #9621 · besu-eth/besu

Matilda-Clerke · 2026-01-12T02:33:07Z

PR description

Utilise SyncTransactionReceipt to avoid unnecessary processing and memory usage during SNAP sync

…ilise raw Bytes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…eipt-in-snap-sync

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…eipt-in-snap-sync

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…eipt-in-snap-sync

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…eipt-in-snap-sync

Matilda-Clerke · 2026-01-14T01:37:04Z

Initial testing shows on-par performance with snap sync on main, so I'm opening this up for review. Please understand that this PR extends from 9574 so will reduce slightly in size once 9574 is merged

Matilda-Clerke · 2026-01-15T04:10:29Z

9574 has now been merged to main, and main merge to this branch

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…ap-sync' into use-synctransactionreceipt-in-snap-sync

jframe · 2026-01-15T23:42:42Z

Initial testing shows on-par performance with snap sync on main, so I'm opening this up for review. Please understand that this PR extends from 9574 so will reduce slightly in size once 9574 is merged

What is the memory usage during sync compare some control nodes, is it less? Can you share JVM memory usage and GC time.

Matilda-Clerke · 2026-01-19T22:59:53Z

Comparing

with

I'm not sure this PR will result in any significant change in memory usage. Curious what others think

Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Matilda-Clerke · 2026-01-30T03:49:34Z

Latest changes are showing a noticeable decreases in garbage collection activity and memory usage.

as well as a reduction in block creation time

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

…ap-sync' into use-synctransactionreceipt-in-snap-sync

Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

pinges

I think this can be improved ...

.../java/org/hyperledger/besu/ethereum/core/encoding/receipt/SyncTransactionReceiptEncoder.java

pinges

LGTM

* Add SyncTransactionReceipt, decoder, and update LogsBloomFilter to utilise raw Bytes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Add unit test for LogBloomFilter changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix missing parentheses in comment in SyncTransactionReceiptDecoder Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Improve unit testing for SyncTransactionReceiptDecoder Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Improve unit testing for SyncTransactionReceiptDecoder Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use random hashes for stateRoot in SyncTransactionReceiptDecoderTest Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Utilise SyncTransactionReceipt in SNAP sync Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix sync tests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Spotless Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix ReceiptsMessage.syncReceipts Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use cumulativeGasUsed instead of cumulativeGas Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Use cumulativeGasUsed instead of cumulativeGas Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Allow variables in SyncTransactionReceipt to be cleared Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix formatting issue Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Update to accomodate merged changes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix compile issues Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Delete now unused GetReceiptsForHeadersTask Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix compile issues after merge Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Avoid decoding and reencoding sync transaction receipts when possible Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> * Fix failing unit tests Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> --------- Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net> Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

…9510 and #9621) Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>

Matilda-Clerke added 24 commits December 16, 2025 07:26

Add SyncTransactionReceipt, decoder, and update LogsBloomFilter to ut…

d720d0e

…ilise raw Bytes Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Add unit test for LogBloomFilter changes

a03a97e

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'main' into add-synctransactionreceipt

3b0a626

Fix missing parentheses in comment in SyncTransactionReceiptDecoder

2068ec9

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Improve unit testing for SyncTransactionReceiptDecoder

67da819

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Improve unit testing for SyncTransactionReceiptDecoder

1dc15bb

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Use random hashes for stateRoot in SyncTransactionReceiptDecoderTest

98da6ba

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'main' into add-synctransactionreceipt

0b4d957

Merge branch 'main' into add-synctransactionreceipt

f7bdc72

Utilise SyncTransactionReceipt in SNAP sync

4776815

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Fix sync tests

f5388d2

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Spotless

03bed9a

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'main' into add-synctransactionreceipt

02ee182

Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…

bf77275

…eipt-in-snap-sync

Fix ReceiptsMessage.syncReceipts

15ced45

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Use cumulativeGasUsed instead of cumulativeGas

ad09745

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Use cumulativeGasUsed instead of cumulativeGas

3a00e6a

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Allow variables in SyncTransactionReceipt to be cleared

52e76c9

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…

785bddf

…eipt-in-snap-sync

Fix formatting issue

c9de7c0

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…

1ddad07

…eipt-in-snap-sync

Update to accomodate merged changes

638313f

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Fix compile issues

f2f23a7

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'add-synctransactionreceipt' into use-synctransactionrec…

d7369f6

…eipt-in-snap-sync

Matilda-Clerke marked this pull request as ready for review January 14, 2026 01:35

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

0abf72c

Matilda-Clerke requested review from jframe and pinges January 15, 2026 04:10

Matilda-Clerke added 2 commits January 15, 2026 15:39

Delete now unused GetReceiptsForHeadersTask

ea2a8d2

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge remote-tracking branch 'origin/use-synctransactionreceipt-in-sn…

475ab4c

…ap-sync' into use-synctransactionreceipt-in-snap-sync

macfarla moved this to Open PRs in 26.1.0 Release Jan 22, 2026

macfarla added this to 26.1.0 Release Jan 22, 2026

Matilda-Clerke added 4 commits January 29, 2026 12:49

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

69759ea

Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

Fix compile issues after merge

ecbe603

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Avoid decoding and reencoding sync transaction receipts when possible

6fb595d

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

118638f

Matilda-Clerke added 3 commits February 2, 2026 09:06

Fix failing unit tests

f8d724b

Signed-off-by: Matilda Clerke <matilda.clerke@consensys.net>

Merge remote-tracking branch 'origin/use-synctransactionreceipt-in-sn…

1185089

…ap-sync' into use-synctransactionreceipt-in-snap-sync

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

6e145bf

Signed-off-by: Matilda-Clerke <matilda.clerke@consensys.net>

pinges reviewed Feb 2, 2026

View reviewed changes

.../java/org/hyperledger/besu/ethereum/core/encoding/receipt/SyncTransactionReceiptEncoder.java Show resolved Hide resolved

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

a98171d

pinges approved these changes Feb 3, 2026

View reviewed changes

Merge branch 'main' into use-synctransactionreceipt-in-snap-sync

31251dd

Matilda-Clerke merged commit 68f8b35 into besu-eth:main Feb 3, 2026
46 checks passed

github-project-automation bot moved this from Open PRs to Done in 26.1.0 Release Feb 3, 2026

pinges mentioned this pull request Feb 10, 2026

Add changelog entry for headers backward and sync transactions PRs #9774

Merged

pinges added a commit that referenced this pull request Feb 10, 2026

add changelog entry for headers backward and sync transactions PRs (#…

82ce653

…9510 and #9621) Signed-off-by: stefan.pingel@consensys.net <stefan.pingel@consensys.net>

macfarla mentioned this pull request Feb 26, 2026

Fix eth/69 receipt encoding for Frontier tx #9900

Merged

10 tasks

macfarla mentioned this pull request Mar 13, 2026

snap - client disconnecting server for Invalid response RESULTS_DO_NOT_MATCH_QUERY #10027

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use SyncTransactionReceipt in SNAP sync#9621

Use SyncTransactionReceipt in SNAP sync#9621
Matilda-Clerke merged 36 commits intobesu-eth:mainfrom
Matilda-Clerke:use-synctransactionreceipt-in-snap-sync

Matilda-Clerke commented Jan 12, 2026

Uh oh!

Matilda-Clerke commented Jan 14, 2026

Uh oh!

Matilda-Clerke commented Jan 15, 2026

Uh oh!

jframe commented Jan 15, 2026

Uh oh!

Matilda-Clerke commented Jan 19, 2026

Uh oh!

Matilda-Clerke commented Jan 30, 2026

Uh oh!

pinges left a comment

Uh oh!

Uh oh!

pinges left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Matilda-Clerke commented Jan 12, 2026

PR description

Uh oh!

Matilda-Clerke commented Jan 14, 2026

Uh oh!

Matilda-Clerke commented Jan 15, 2026

Uh oh!

jframe commented Jan 15, 2026

Uh oh!

Matilda-Clerke commented Jan 19, 2026

Uh oh!

Matilda-Clerke commented Jan 30, 2026

Uh oh!

pinges left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pinges left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants