Use bonsai code cache in ExtCodeSizeOperation#9634
Closed
daniellehrner wants to merge 4 commits intobesu-eth:mainfrom
Closed
Use bonsai code cache in ExtCodeSizeOperation#9634daniellehrner wants to merge 4 commits intobesu-eth:mainfrom
daniellehrner wants to merge 4 commits intobesu-eth:mainfrom
Conversation
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
Signed-off-by: daniellehrner <daniel.lehrner@consensys.net>
daniellehrner
commented
Jan 14, 2026
| } | ||
| // Any other account can only use the code bytes directly | ||
| else { | ||
| codeSize = Words.intBytes(account.getCode().size()); |
Contributor
Author
There was a problem hiding this comment.
I am currently unsure if Forest accounts would benefit from evm.getOrCreateCachedJumpDest(). The old logic is a bit confusing, as we first get the code bytes from the state before checking the cache
Contributor
Author
|
It seems the code size is already cached because the byte instance has the size already calculated when the object is created |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Fixed Issue(s)
Thanks for sending a pull request! Have you done the following?
doc-change-requiredlabel to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew spotlessApply./gradlew build./gradlew acceptanceTest./gradlew integrationTest./gradlew ethereum:referenceTests:referenceTests