Skip to content

Fix promotion to prioritized layer for gas price fee markets#9635

Merged
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:fix-min-gas-price-promotion-layered-txpool
Jan 20, 2026
Merged

Fix promotion to prioritized layer for gas price fee markets#9635
fab-10 merged 1 commit intobesu-eth:mainfrom
fab-10:fix-min-gas-price-promotion-layered-txpool

Conversation

@fab-10
Copy link
Copy Markdown
Contributor

@fab-10 fab-10 commented Jan 14, 2026

PR description

This is a bug fix that corrects the gas price validation logic in the layered transaction pool. The change
allows transactions with gas price exactly equal to the minimum gas price to be promoted, which was
incorrectly rejected before.

Fixed Issue(s)

fixes #9598

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests
  • hive tests: Engine or other RPCs modified?

@jflo jflo added the non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT label Jan 14, 2026
@fab-10 fab-10 marked this pull request as ready for review January 14, 2026 14:20
Copilot AI review requested due to automatic review settings January 14, 2026 14:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@fab-10 fab-10 added the bug Something isn't working label Jan 19, 2026
@github-project-automation github-project-automation bot moved this to To triage in Besu Bugs Jan 19, 2026
Copy link
Copy Markdown
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth a changelog since it was a reported bug?

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
@fab-10 fab-10 force-pushed the fix-min-gas-price-promotion-layered-txpool branch from 17f4513 to b5408f7 Compare January 20, 2026 14:40
@fab-10 fab-10 enabled auto-merge (squash) January 20, 2026 14:40
@fab-10 fab-10 merged commit ccd0bf1 into besu-eth:main Jan 20, 2026
46 checks passed
@github-project-automation github-project-automation bot moved this from To triage to Done in Besu Bugs Jan 20, 2026
@fab-10 fab-10 deleted the fix-min-gas-price-promotion-layered-txpool branch January 20, 2026 15:13
macfarla pushed a commit to CPerezz/besu that referenced this pull request Feb 6, 2026
…h#9635)

Signed-off-by: Fabio Di Fabio <fabio.difabio@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non mainnet (private networks) not related to mainnet features - covers privacy, permissioning, IBFT2, QBFT

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transaction Pool Bug: Transactions Permanently Stuck After Failed/Reverted Transactions Are Removed

5 participants