Fix critical pyyawt dependency and improve algorithm stability #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace non-existent pyyawt module with PyWavelets in iterative Wiener deconvolution - Implement proper noise estimation using MAD method - Add bounds checking to prevent index errors - Update dependencies in requirements.txt and setup.py - Fix deprecated GIFTI file handling in spm.py - Improve error handling and numerical stability - Update unit tests to match algorithm changes.
Restructure README to highlight fixes for maintainers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses critical compatibility issues that prevent rsHRF from running on modern Python environments.
Issues Fixed:
Testing:
All existing unit tests have been updated and pass with the new dependencies. The mathematical accuracy of the HRF estimation is preserved - only implementation details have been modernized.
Compatibility:
These fixes ensure rsHRF works with:
Without these fixes, the package is currently unusable due to the pyyawt dependency issue.