Ensure /v1/cert.pem endpoint reads certificates after rotation#218
Merged
Ensure /v1/cert.pem endpoint reads certificates after rotation#218
Conversation
mkmik
force-pushed
the
fixservecert
branch
4 times, most recently
from
680df76 to
415a21e
Compare
atomatt
approved these changes
Aug 27, 2019
| certUtil "k8s.io/client-go/util/cert" | ||
| ) | ||
|
|
||
| func TestHttpCert(t *testing.T) { |
There was a problem hiding this comment.
I see this is a new file so I assume there were no tests for the /v1/cert.pem endpoint until now? Thanks for adding one!
However, should there be a distinct test that replaces cert once the server is running (simulating a key rotation) and checks the latest cert is returned?
Contributor
Author
There was a problem hiding this comment.
thanks for encouraging me to write a proper test :-p
done
Contributor
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#143 introduced key rotation, but we didn't update the cert.pem serving path