Skip to content

fix: fix file tests#697

Merged
boyter merged 1 commit intoboyter:masterfrom
apocelipes:fix-file-test
Apr 13, 2026
Merged

fix: fix file tests#697
boyter merged 1 commit intoboyter:masterfrom
apocelipes:fix-file-test

Conversation

@apocelipes
Copy link
Copy Markdown
Contributor

@apocelipes apocelipes commented Apr 13, 2026

#694 causes too many test fail:
image

image

Fix them and do some clean up:

  • Clean up visitedPaths map when necessary
  • Fix tests, especially on macOS, where temporary file directories are symbolic links.
  • Move symlink integration tests to go tests

@pr-insights pr-insights Bot added M/complexity Normal or medium complexity M/size Normal or medium sized change and removed M/size Normal or medium sized change M/complexity Normal or medium complexity labels Apr 13, 2026
@boyter
Copy link
Copy Markdown
Owner

boyter commented Apr 13, 2026

Thats on me, I didnt run them. Thanks for fixing.

I was going to do it later tonight.

@boyter boyter merged commit 515f91c into boyter:master Apr 13, 2026
4 checks passed
@apocelipes apocelipes deleted the fix-file-test branch April 13, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

M/complexity Normal or medium complexity M/size Normal or medium sized change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants