Skip to content

Feature: enable server-side-rendering #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2018
Merged

Feature: enable server-side-rendering #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d551b0d
Conditionally require picturefill to allow SSR
brettgullan Oct 17, 2017
b083f83
Add can-use-dom
brettgullan Oct 25, 2017
52825a9
fix: Add canUseDom guard on ieVersion check
brettgullan Oct 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"react-dom": "^15.0.1"
},
"dependencies": {
"can-use-dom": "^0.1.0",
"glamorous": "^3.23.3",
"picturefill": "^3.0.2",
"prop-types": "^15.5.10"
Expand Down
13 changes: 10 additions & 3 deletions src/components/Picture.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
import React from "react";
import PropTypes from "prop-types";
import picturefill from "picturefill";
import glamorous from "glamorous";
import canUseDom from 'can-use-dom'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that can-use-dom is literally a function, what's your opinion on adding a dependency vs just defining that function in the library?

I know that npm is much more secure now and the chances something goes wrong are small, but given that the function defined isn't really something that we expect to change in the future I was more on the side of defining the function in our code instead of importing another dependency.


const Img = glamorous.img();

class Picture extends React.PureComponent {
componentDidMount() {
picturefill();
// c.f. https://github.com/scottjehl/picturefill/pull/556
var picturefill;
try {
picturefill = require('picturefill');
} catch(x) {}

if (picturefill) picturefill(); // browser
// else node
}

renderSources() {
const ieVersion = document.documentMode ? document.documentMode : -1;
const ieVersion = canUseDom && document.documentMode ? document.documentMode : -1;
const { sources } = this.props;

if (sources == null) {
Expand Down