Skip to content
This repository was archived by the owner on Oct 22, 2019. It is now read-only.

Romanian translations#500

Merged
swistakm merged 2 commits into
bread-and-pepper:masterfrom
aramboi:master
Nov 18, 2015
Merged

Romanian translations#500
swistakm merged 2 commits into
bread-and-pepper:masterfrom
aramboi:master

Conversation

@aramboi
Copy link
Copy Markdown
Contributor

@aramboi aramboi commented Nov 16, 2015

No description provided.

@swistakm
Copy link
Copy Markdown
Contributor

@aramboi thanks for contribution!

I don't know why build failed for django 1.4. It should not because this affects only translations. It seems that it userena is broken with new version of django-guardian that was released recently.

So I merge it because it is safe but this will be released only when I figure out how to handle this broken build situation.

swistakm added a commit that referenced this pull request Nov 18, 2015
Add romanian translations
@swistakm swistakm merged commit d0b39a0 into bread-and-pepper:master Nov 18, 2015
@aramboi
Copy link
Copy Markdown
Contributor Author

aramboi commented Nov 18, 2015

Seems like django-guardian dropped support for Django below 1.5 with the latest 1.3.2 version. Commit: django-guardian/django-guardian@35f6314

For me it's not an issue as I don't need the translations right away. I actually created them quite a while ago and forgot, then found them a few days ago, cleaned them a bit and pushed the PR. :)

@aramboi
Copy link
Copy Markdown
Contributor Author

aramboi commented Nov 18, 2015

I think this is mainly because support ended for Django 1.4 LTS on October 1.

@swistakm
Copy link
Copy Markdown
Contributor

Yeah i noticed that change but I think no package should do such things in a point release. We will also eventually drop django 1.4 but we definitely won't go that way. Such things deserve major or at least minor version release.

Shame on you django-guardian!

@aramboi
Copy link
Copy Markdown
Contributor Author

aramboi commented Nov 19, 2015

I agree. Backwards incompatible changes shouldn't be part of a patch release. Then again that is up to the package maintainers and their release policy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants