Utilize 'unit struct' where appropriate. #122
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I agree to license my contributions to each file under the same terms given at the top of each file I changed.
| struct EdDSA { | ||
| _unused: u8, // XXX: Stable Rust doesn't allow empty structs. | ||
| } | ||
| struct EdDSA; |
There was a problem hiding this comment.
Alternatively, this could be written:
struct EdDSA { }...which was not stable in 1.0 (rust-lang/rfcs#218).
|
Thanks! I was pretty sure that this didn't work before but I guess I was confiused. Committed as 9224062. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.