Skip to content

Add suggested changes from review of PR 190 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 10, 2025
Merged

Add suggested changes from review of PR 190 #4

merged 4 commits into from
Apr 10, 2025

Conversation

dlqqq
Copy link

@dlqqq dlqqq commented Apr 9, 2025 •
edited
Loading

Description

  • Removes type casts from LabChatContext and MentionCommandProvider.
  • Adds the users property to IChatContext to remove the need for type-casting.
  • Makes ChatContext abstract and renames it to AbstractChatContext. The users property is left abstract.
  • Fixes the unit tests and moves mock classes (MockChatModel, MockChatContext) into a separate file, mocks.ts.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2025

Binder 👈 Launch a Binder on branch dlqqq/jupyter-chat/user_mention_dlqqq

@dlqqq dlqqq mentioned this pull request Apr 9, 2025
Merged
@brichet
Copy link
Owner

brichet commented Apr 10, 2025

Let's move forward, thanks @dlqqq

@brichet brichet merged commit 6bf9fed into brichet:user_mention Apr 10, 2025
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlqqq @brichet