Fix validating hash on uncompressed storage #819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostynb
reviewed
May 4, 2025
| @@ -352,7 +352,7 @@ func (c *diskCache) writeAndCloseFile(ctx context.Context, r io.Reader, kind cac | |||
| var err error | |||
| var sizeOnDisk int64 | |||
|
|
|||
| if kind == cache.CAS && c.storageMode != casblob.Identity { | |||
| if kind == cache.CAS { | |||
There was a problem hiding this comment.
Why isn't this change alone sufficient (and why is the casblob.go refactoring required) ? It's hard to tell in the github UI.
There was a problem hiding this comment.
The WriteAndCose method computed and wrote the CAS blob header (here) even when Identity was passed, but uncompressed expects the blobs to be plain
Co-authored-by: Mostyn Bramley-Moore <[email protected]>
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 7, 2025
This seems to have been unchecked since v2.0.0. Alternative fix to buchgr#819.
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 7, 2025
This seems to have been unchecked since v2.0.0. Alternative fix to buchgr#819.
mostynb
added a commit
to mostynb/bazel-remote
that referenced
this pull request
Jun 7, 2025
This seems to have been unchecked since v2.0.0. Alternative fix to buchgr#819.
|
Sorry it took so long to get to this. I refactored your test a bit and then implemented a simpler fix which doesn't touch casblob: #826 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storage mode is
uncompressed, cas blobs are not validated against their sha and accepted regardless. The validation is instead performed when usingzstdstorage mode. This refactorscasbob.WriteAndCloseto write both compressed and uncompress blobs and validate their content.