When AUTO_LETS_ENCRYPT == "no" the content should be empty #2456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When AUTO_LETS_ENCRYPT == "no" the content should be empty
Michal-Koeckeis-Fresel
requested review from
TheophileDiot and
fl0ppy-d1sk
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR updates the conditional configuration for Let's Encrypt challenge handling so that the content is rendered only when AUTO_LETS_ENCRYPT is set to "yes" and LETS_ENCRYPT_PASSTHROUGH is "no".
- Updated condition in both server-http and default-server-http configuration files
- Ensures that when AUTO_LETS_ENCRYPT is "no", no challenge configuration is rendered
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/common/core/letsencrypt/confs/server-http/lets-encrypt.conf | Updated the conditional to include AUTO_LETS_ENCRYPT check |
| src/common/core/letsencrypt/confs/default-server-http/lets-encrypt.conf | Updated the conditional to include AUTO_LETS_ENCRYPT check |
Comments suppressed due to low confidence (2)
src/common/core/letsencrypt/confs/server-http/lets-encrypt.conf:1
- Consider adding a comment to explain the new condition and its relation to AUTO_LETS_ENCRYPT for clarity to future maintainers.
{% if AUTO_LETS_ENCRYPT == "yes" and LETS_ENCRYPT_PASSTHROUGH == "no" %}
|
Closed in a hurry before code was commited to dev branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When AUTO_LETS_ENCRYPT == "no" the content should be empty