Fix sqlite3 bindings and revert sqlite support#71
Merged
tianzhou merged 2 commits intobytebase:mainfrom Jun 26, 2025
Merged
Conversation
The issue occurred because of changes in version 10 of pnpm, which broke better-sqlite3 installation. More details here: WiseLibs/better-sqlite3#1378 (comment)
This reverts commit afe71d3.
Contributor
Author
|
Tested by building the container with |
tianzhou
added a commit
that referenced
this pull request
Jun 26, 2025
Bring SQLite back thanks to #71
Member
|
I have verified the fix and bumped the package to 0.10.0. Thanks! |
Closed
Contributor
Author
|
Thank you! |
AdamerKocoloski
added a commit
to AdamerKocoloski/dbhub
that referenced
this pull request
Dec 31, 2025
Bring SQLite back thanks to bytebase/dbhub#71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue occurred because of changes in version 10 of pnpm, which broke
better-sqlite3 installation. More details here:
WiseLibs/better-sqlite3#1378 (comment)