Extract correct version when using --with flag to replace Caddy core#216
Merged
mholt merged 1 commit intocaddyserver:masterfrom Dec 1, 2024
jshenguru:master
Merged
Extract correct version when using --with flag to replace Caddy core#216mholt merged 1 commit intocaddyserver:masterfrom jshenguru:master
mholt merged 1 commit intocaddyserver:masterfrom
jshenguru:master
Conversation
mholt
approved these changes
Dec 1, 2024
Member
mholt
left a comment
There was a problem hiding this comment.
Cool, thanks for the patch. LGTM
|
Could a new release be drafted up that includes these changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following build failed on Windows with
Invalid Semantic Versionerror.xcaddy build v2.8.4 --with github.com/caddyserver/caddy/v2=c:\Users\test\caddyThe bug is among lines 97 - 110 in the builder.go.
Detailed explanation:
The
go list -mcommand in this case would returngithub.tiyicn.workers.dev/caddyserver/caddy/v2 v2.8.4 => c:\Users\test\caddy. The value of theversionwould end up beingv2.8.4 => c:\Users\test\Documents\EyeSCADA-v4\_esRouter\caddy-2.8.4. Therefore, theutils.WIndows Resource()call would fail with 'Invalid Semantic Version` error.A quick fix would be adding the following between
version := ...anderr = util.WIndowsResource(...):