Shuffle regex #112
Merged
Shuffle regex #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleb531
requested changes
Dec 5, 2022
There was a problem hiding this comment.
@eliotwrobson A few very small things, and I'd also add that this new operator is missing documentation under docs/regular-expressions.md. But otherwise, looks great!
Thank you as always for your thoughtful and well-written contributions.
|
@caleb531 addressed all the items and added docs! I think we'll want to wait for Eduardo to review before merging though, since he originally requested this. |
caleb531
requested changes
Dec 6, 2022
There was a problem hiding this comment.
@eliotwrobson Left some feedback on the existing comment threads.
caleb531
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added shuffle product to regex. @EduardoGoulart1 and @caleb531 resolves part of the issue in #109.