Skip to content

Setting up UV #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 6, 2025
Merged

Setting up UV #254

merged 7 commits into from
May 6, 2025

Conversation

eliotwrobson
Copy link
Collaborator

Resolves #253

@eliotwrobson eliotwrobson self-assigned this Apr 2, 2025
@eliotwrobson
Copy link
Collaborator Author

@caleb531 so it appears this was a lot easier than expected. I don't think this is quite in a stage to merge yet (I'm not sure exactly how you want to set up the publish workflow), but I think this is a strong proof of concept so far. I might need your input on how we want to test this fully before merging, since this is a pretty sizeable change, but overall I think simplifies the CI configuration.

@coveralls
Copy link

coveralls commented Apr 2, 2025

Coverage Status

coverage: 99.613%. remained the same
when pulling bcd6b80 on eliotwrobson:uv
into 1bdf9b7 on caleb531:develop.

@eliotwrobson
Copy link
Collaborator Author

@caleb531 do you have any thoughts about the publish workflow? That's the only one that I haven't yet changed in this PR. The docs building one should work but I haven't tested it.

@caleb531
Copy link
Owner

@eliotwrobson I think you just need to update the publish workflow to build the project properly with uv to generate the wheel and other distributions (can't remember everything that gets generated). The step is called "Build a binary wheel and a source tarball" in publish.yml. But I think once the project is built in the context of the GHA workflow runtime, it gets deployed from there. Granted, I haven't found any pypa/gh-action-pypi-publish documentation related to uv.

If we want to test this, we can try pushing a dev or alpha prerelease or something. The publish workflow gets triggered when a tag is created, regardless of which branch it is on.

@eliotwrobson eliotwrobson marked this pull request as ready for review April 15, 2025 18:15
@eliotwrobson
Copy link
Collaborator Author

@caleb531 did you have a chance to take a look at this? If not, I think it's probably ok to just merge and debug later.

@calebevans-modeln
Copy link

@eliotwrobson Ah, my apologies. It's been a busy few weeks. Let me merge now.

@caleb531 caleb531 merged commit c477062 into caleb531:develop May 6, 2025
16 checks passed
@caleb531 caleb531 mentioned this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants