-
Notifications
You must be signed in to change notification settings - Fork 70
uv
improvements
#262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
uv
improvements
#262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.venv is the default virtualenv directory name for uv. It can be changed at a user level by setting UV_PROJECT_ENVIRONMENT to the desired name, however for those who don't set this variable, we still want to make sure that Git ignores the default virtualenv.
I tend to add a shebang line to every file regardless of whether or not it's actually executable.
8dfb1ef
to
505ff57
Compare
eliotwrobson
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small questions but mostly seems good! I didn't expect uv to require too many changes to the instructions.
In VS Code settings.
Now that we are using uv.
@eliotwrobson Now that all comment threads are resolved, I will be merging this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eliotwrobson I realized we forgot to update the Contributing guide with documentation on how to set up
uv
. I've updated it below, along with a few other necessary improvements (like adding uv's default virtualenv name to our.gitignore
).Please take a look and let me know what you think!