Skip to content

Revert "fix: getAllBy* methods return more elements than expected (#57)" #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

thymikee
Copy link
Member

This reverts commit d6d225d.

Summary

Turned out that causes issues with testing some components, especially on RN prior to 0.57.5 (but also there). We need to update our testing suite to include all components exposed by react-native and implement getNodeByName properly.

Test plan

should be green

@thymikee thymikee merged commit 01249f6 into master Nov 14, 2018
@thymikee thymikee deleted the revert-d6d225d branch November 14, 2018 13:07
@pvinis pvinis mentioned this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant