Two-level Malware Bug #315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into multi-level-bug Merge
eric-pSAP
force-pushed
the
multi-level-bug
branch
from
6d355d0 to
1138793
Compare
eric-pSAP
force-pushed
the
multi-level-bug
branch
from
ef51772 to
4f49be4
Compare
Contributor
Author
|
With the recent push it exposed a bug in the code where deleteAttachmentsWithKeys is called twice when we discard a draft: once from the CANCEL after handler and once from the DELETE/UPDATE after handler. Will fix that next |
… into multi-level-bug
… into multi-level-bug
schiwekM
reviewed
Dec 9, 2025
| diffData[attachmentsComp]?.forEach(object => { | ||
| if (object._op === "delete") { | ||
| deletedAttachments.push(object.ID) | ||
| const deletedAttachments = (() => { |
Contributor
There was a problem hiding this comment.
This should be restructured to avoid the inline function call
schiwekM
requested changes
Dec 9, 2025
Contributor
schiwekM
left a comment
schiwekM
left a comment
There was a problem hiding this comment.
Looks quite nice - thanks for fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing for malware bug that occurs in the child of two-level entities, as reported in issue #235. Currently I am unable to replicate the error, it may have been resolved in a previous PR.