Skip to content

Commit b486103

Browse files
grishma-shah7maxi-smidtGururajj77heloiseluikennylam
authored
fix: added missing accessibility labels for pagination elements (#21051)
* fix: added missing accessibility labels for pagination elements * fix: update contribution * Fix formatting for cds-callout-notification section (#21036) Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> * feat(dropdown): reintroduce parity changes from reverted PR #20863 (#21048) * feat(dropdown): reintroduce parity changes from reverted PR #20863 * fix(multi-select): ensure input reflects aria-expanded state * fix: address review comment * chore(styles): update Sass API for web component builds (#21044) * chore(styles): update sass api for web component builds * chore(styles): update deprecated type-of() in theme --------- Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> * fix(combobox): sync menu highlight with controlled selection (#21064) --------- Co-authored-by: Maximilian Smidt <[email protected]> Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> Co-authored-by: kennylam <[email protected]>
1 parent b44ef68 commit b486103

File tree

4 files changed

+12
-0
lines changed

4 files changed

+12
-0
lines changed

.all-contributorsrc

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1573,6 +1573,15 @@
15731573
"contributions": [
15741574
"code"
15751575
]
1576+
},
1577+
{
1578+
"login": "grishma-shah7",
1579+
"name": "Grishma Shah",
1580+
"avatar_url": "https://avatars.githubusercontent.com/u/87775713?v=4",
1581+
"profile": "https://github.com/grishma-shah7",
1582+
"contributions": [
1583+
"a11y"
1584+
]
15761585
}
15771586
],
15781587
"commitConvention": "none"

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -377,6 +377,7 @@ check out our [Contributing Guide](/.github/CONTRIBUTING.md) and our
377377
<td align="center"><a href="https://github.com/mateus037"><img src="https://avatars.githubusercontent.com/u/34143412?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Mateus Rodrigues</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=mateus037" title="Code">💻</a></td>
378378
<td align="center"><a href="https://github.com/BiaBiruka"><img src="https://avatars.githubusercontent.com/u/128196689?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Beatriz Parolin</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=BiaBiruka" title="Code">💻</a></td>
379379
<td align="center"><a href="https://github.com/trumanbutter"><img src="https://avatars.githubusercontent.com/u/32148874?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Truman Butterworth</b></sub></a><br /><a href="https://github.com/carbon-design-system/carbon/commits?author=trumanbutter" title="Code">💻</a></td>
380+
<td align="center"><a href="https://github.com/grishma-shah7"><img src="https://avatars.githubusercontent.com/u/87775713?v=4?s=100" width="100px;" alt=""/><br /><sub><b>Grishma Shah</b></sub></a><br /><a href="#a11y-grishma-shah7" title="Accessibility">️️️️♿️</a></td>
380381
</tr>
381382
</table>
382383

packages/web-components/src/components/button/button.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,7 @@ class CDSButton extends HostListenerMixin(FocusMixin(LitElement)) {
404404
?disabled="${disabled}"
405405
tabindex="${tabIndex}"
406406
type="${ifDefined(type)}"
407+
aria-label="${ifDefined(tooltipText)}"
407408
aria-describedby="badge-indicator">
408409
${isDanger
409410
? html`<span class="${prefix}--visually-hidden"

packages/web-components/src/components/select/select.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -462,6 +462,7 @@ class CDSSelect extends FormMixin(LitElement) {
462462
id="input"
463463
class="${inputClasses}"
464464
?disabled="${disabled}"
465+
title="${value}"
465466
aria-readonly="${String(Boolean(readonly))}"
466467
aria-invalid="${String(Boolean(invalid))}"
467468
aria-describedby="${ifDefined(describedBy)}"

0 commit comments

Comments
 (0)