fix(dropdown): align styles and behavior with React parity #20863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heloiselui
added
status: visual review 🔍
package: @carbon/web-components
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #20863 +/- ##
==========================================
- Coverage 92.39% 85.57% -6.82%
==========================================
Files 515 357 -158
Lines 37629 14501 -23128
Branches 5740 4903 -837
==========================================
- Hits 34766 12409 -22357
+ Misses 2714 1952 -762
+ Partials 149 140 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
maradwan26
reviewed
Nov 6, 2025
Contributor
There was a problem hiding this comment.
Nice work! Just a few comments:
- The warn icon overlaps when the text is long
the invalid icon works fine, though
- When toggling disabled on then turning it off, the items remain disabled
- Some changes are bleeding into the multi-select component causing regressions (can't type in filterable input, list closes after selection, styles, hovering over items, etc.)
Screen.Recording.2025-11-06.at.11.31.25.AM.mov
- The combobox component is also inheriting some of the focus management from dropdown, too
Gururajj77
approved these changes
Nov 14, 2025
Merged
via the queue into
carbon-design-system:main
with commit Nov 14, 2025
18b87e5
40 of 43 checks passed
heloiselui
added a commit
to heloiselui/carbon
that referenced
this pull request
Nov 18, 2025
3 tasks
grishma-shah7
pushed a commit
to grishma-shah7/carbon
that referenced
this pull request
Nov 24, 2025
…sign-system#20863 (carbon-design-system#21048) * feat(dropdown): reintroduce parity changes from reverted PR carbon-design-system#20863 * fix(multi-select): ensure input reflects aria-expanded state
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
* fix: added missing accessibility labels for pagination elements * fix: update contribution * Fix formatting for cds-callout-notification section (#21036) Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> * feat(dropdown): reintroduce parity changes from reverted PR #20863 (#21048) * feat(dropdown): reintroduce parity changes from reverted PR #20863 * fix(multi-select): ensure input reflects aria-expanded state * fix: address review comment * chore(styles): update Sass API for web component builds (#21044) * chore(styles): update sass api for web component builds * chore(styles): update deprecated type-of() in theme --------- Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> * fix(combobox): sync menu highlight with controlled selection (#21064) --------- Co-authored-by: Maximilian Smidt <[email protected]> Co-authored-by: Gururaj J <[email protected]> Co-authored-by: Heloise Lui <[email protected]> Co-authored-by: kennylam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18332
Update
<cds-dropdown>Web Component to match React component parity.Changelog
New
ArrowUp,ArrowDown,Enter,Space)Changed
cds-dropdown-beingselected,cds-dropdown-beingtoggled, etc.)argsandargTypesRemoved
Testing / Reviewing
WC Deploy Preview>Dropdowncompare with the ReactDropdown.disabled,invalid,warn,readOnly,size,type...) behave consistently. (I open a separate issue to implement the autoAlign prop).EnterandSpaceopen/close and select itemsArrowUpandArrowDownnavigate between itemsautoAligncontrols #20859 to implementautoAlign)PR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Wrote passing tests that cover this changeMore details can be found in the pull request guide