Skip to content

Conversation

@tay1orjones
Copy link
Member

Closes #19644

Small update to not place aria-describedby w/ the helperText id when the input is invalid and helperText is not shown/rendered.

Changelog

Changed

  • update filterablemultiselect aria-describedby logic w/ a new test

Testing / Reviewing

  • Go to the ?path=/story/components-multiselect--filterable-with-select-all&args=helperText:something;invalid:!true story
  • Make sure that the helperText prop is set to something and invalid is true
  • Open the story in the popout iframe and run ac checker
  • You should see no violations

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
    - [ ] Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@tay1orjones tay1orjones requested a review from a team as a code owner October 15, 2025 21:24
@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit f59eab2
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/68f69a61d786580008737548
😎 Deploy Preview https://deploy-preview-20738--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit f59eab2
🔍 Latest deploy log https://app.netlify.com/projects/carbon-elements/deploys/68f69a611e35cc0008a445d3
😎 Deploy Preview https://deploy-preview-20738--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit f59eab2
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/68f69a615542a600078cfb34
😎 Deploy Preview https://deploy-preview-20738--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.12%. Comparing base (30b4f87) to head (f59eab2).
⚠️ Report is 317 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20738      +/-   ##
==========================================
+ Coverage   91.39%   92.12%   +0.73%     
==========================================
  Files         485      509      +24     
  Lines       31370    35687    +4317     
  Branches     5430     5655     +225     
==========================================
+ Hits        28670    32876    +4206     
- Misses       2547     2663     +116     
+ Partials      153      148       -5     
Flag Coverage Δ
main-packages 85.41% <100.00%> (+0.48%) ⬆️
web-components 96.68% <ø> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@heloiselui heloiselui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed, the PR resolves this issue.

I noticed we have the same problem when warn is true: "The 'id' 'filterablemultiselect-helper-text-id-«r4»' specified for the ARIA property 'aria-describedby' value is not valid." - not sure if you want open a new issue for that.

I also noticed that in the Default example, in controls, both invalidText and warnText use "Whoopsie!" as sample content. I think it would be nice to include that in all the other story examples as well, and add something similar for helperText, but just thinking out loud.

@tay1orjones
Copy link
Member Author

@heloiselui great catch, thanks! I updated to fix the warn bit

@tay1orjones tay1orjones enabled auto-merge October 20, 2025 20:24
@tay1orjones tay1orjones added this pull request to the merge queue Oct 20, 2025
Merged via the queue into carbon-design-system:main with commit 56f3f3d Oct 20, 2025
42 of 43 checks passed
@tay1orjones tay1orjones deleted the 19644-filterablemultiselect-aria branch October 20, 2025 21:20
@carbon-automation
Copy link
Contributor

Hey there! v11.94.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y]: 4.1.2 Name, Role, Value Violation from <FilterableMultiSelect /> aria-describedby label

3 participants