-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix(FilterableMultiSelect): no aria-describedby helperText when invalid #20738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FilterableMultiSelect): no aria-describedby helperText when invalid #20738
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20738 +/- ##
==========================================
+ Coverage 91.39% 92.12% +0.73%
==========================================
Files 485 509 +24
Lines 31370 35687 +4317
Branches 5430 5655 +225
==========================================
+ Hits 28670 32876 +4206
- Misses 2547 2663 +116
+ Partials 153 148 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and confirmed, the PR resolves this issue.
I noticed we have the same problem when warn is true: "The 'id' 'filterablemultiselect-helper-text-id-«r4»' specified for the ARIA property 'aria-describedby' value is not valid." - not sure if you want open a new issue for that.
I also noticed that in the Default example, in controls, both invalidText and warnText use "Whoopsie!" as sample content. I think it would be nice to include that in all the other story examples as well, and add something similar for helperText, but just thinking out loud.
|
@heloiselui great catch, thanks! I updated to fix the |
56f3f3d
|
Hey there! v11.94.0 was just released that references this issue/PR. |
Closes #19644
Small update to not place
aria-describedbyw/ the helperText id when the input isinvalidand helperText is not shown/rendered.Changelog
Changed
Testing / Reviewing
invalidistruePR Checklist
As the author of this PR, before marking ready for review, confirm you:
- [ ] Updated documentation and storybook examplesMore details can be found in the pull request guide