fix(web-components): move @carbon/icons to dependencies
#21106
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennylam
approved these changes
Dec 2, 2025
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #21106 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 515 515
Lines 38225 38225
Branches 5835 5835
=======================================
Hits 35397 35397
Misses 2678 2678
Partials 150 150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
riddhybansal
approved these changes
Dec 3, 2025
Merged
via the queue into
carbon-design-system:main
with commit Dec 3, 2025
7da22c2
42 of 43 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21081
Moves
@carbon/iconsfrom "devDependencies" to "dependencies" to fix an issue where a dependency error would get thrown when importing certain components fromes/components/Changelog
Changed
@carbon/iconsfrom "devDependencies" to "dependencies"Testing / Reviewing
yarn installandyarn buildcdto packages/web-componentsnpm pack.tgzfile generated fromnpm packand paste it into your local version of the stackblitz reproductionpackage.jsonand set"@carbon/web-components": "file:./carbon-web-components-rest-of-file-name.tgz"yarn cleanif needednpm install && npm run devPR Checklist
As the author of this PR, before marking ready for review, confirm you:
[ ] Updated documentation and storybook examples[ ] Wrote passing tests that cover this change[ ] Addressed any impact on accessibility (a11y)[ ] Tested for cross-browser consistencyMore details can be found in the pull request guide