-
Notifications
You must be signed in to change notification settings - Fork 13
New step remove sftp file #952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4cdb88d
to
69241a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this also have unit tests added? e.g. see https://github.com/catalyst/moodle-tool_dataflows/blob/MOODLE_405_STABLE/tests/tool_dataflows_sftp_test.php
Since there's no actual SFTP to test against, it might just end up being a test for 1. sanity check that step loads properly, and 2. testing that source is always a remote, and errors otherwise
Another thought - could this also be added as a flow step just for consistency - you should be able to share most of the functionality with the trait |
@matthewhilton Thank you for the review. |
323bed9
to
e657c3d
Compare
e657c3d
to
c2c4e61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave this a test locally and works as expected, including field validation (for reference, I used https://hub.docker.com/r/atmoz/sftp)
Just 1 tiny change regarding some lang strings.
Also because we changing the lang strings the version.php needs a bump
Thanks for updating those lang strings @gbarat87 - the CI is failing now because of the php copy paste detector. Honestly i'd be open to disabling it to get the ci green as it isn't super valuable. |
This step is to remove a file from the sftp server.
This is needed as there is no possibility to move a file from a folder to another in the sftp server.
The step "sftp copy file" following by this new one can allows one to move a file around.