This repository was archived by the owner on May 22, 2023. It is now read-only.
adding support for specifying dns suffix for hostnames. Also doing #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some refactoring to avoid custom decoding.
…-set-host-suffix Conflicts: server/src/main/java/com/continuuity/loom/http/LoomClusterHandler.java server/src/test/java/com/continuuity/loom/http/LoomRPCHandlerTest.java
Contributor
|
LGTM for frontend |
Contributor
|
test/page/CreatePage/GenericPage - 'information' is spelt incorrectly in javadocs |
Contributor
There was a problem hiding this comment.
If you declare these label Strings (e.g. "imagetype", "numMachines") as public static final variables in ClusterRequest, you can refer to them directly in this file, ClusterDefaultsCodec, ClusterDefaults and ClusterRequest
Contributor
Author
There was a problem hiding this comment.
ClusterDefaults doesn't have the same fields. For example, numMachines is only in the cluster request and not in defaults.
Contributor
|
Some comments, otherwise LGTM |
albertshau
added a commit
that referenced
this pull request
Mar 28, 2014
…uffix adding support for specifying dns suffix for hostnames. Also doing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some refactoring to avoid custom decoding.