Skip to content

Document that ReactTapEventPlugin(js.undefined) is needed in JSApp body #86

Open
@beikern

Description

@beikern

If ReactTapEventPlugin(js.undefined) is not provided in the JsApp body the browser's console throws the following warning:

warning.js:36 Warning: Unknown prop `onTouchTap` on <button> tag. Remove this prop from the element. For details, see https://fb.me/react-unknown-prop
    in button (created by EnhancedButton)
    in EnhancedButton (created by FlatButton)
    in FlatButton (created by NavToolBar)
    in div (created by ToolbarGroup)
    in ToolbarGroup (created by NavToolBar)
    in div (created by Toolbar)
    in Toolbar (created by NavToolBar)
    in NavToolBar (created by Router)
    in MuiThemeProvider (created by Router)
    in div (created by Router)
    in nav (created by Router)
    in div (created by Router)
    in Router

Just putting it in the JsApp solves the warning, just like this:

object MyApp extends JSApp {
  //TODO: dev-server complains that we load several times?
  ReactTapEventPlugin(js.undefined)

  @JSExport
  override def main(): Unit = {
    val baseTheme = Mui.Styles.LightRawTheme
    val theme: MuiTheme =
      Mui.Styles.getMuiTheme(baseTheme)

    AppCSS.load()
    val router = MuiMuiThemeProvider(muiTheme = theme)(AppRouter.router())
    router.renderIntoDOM(dom.document.getElementById("content"))

    ()
  }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions