Load binary files without global state conflicts #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is in preparation to making the loading of several binary files possible: for that visitCilFile is needed.
We add the ability to load several binary files at any moment, by inspecting the binary file, computing a new mapping of its varinfo vid and compinfo ckey fields so that they are compatible with the current nextGlobalVID and nextCompinfoKey, and applying the mapping to the loaded file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this commit adds the ability to use loadBinaryFile at leisure, without having global state problems thereafter. The algorithm to do so is imho simple enough, without causing vid or ckey overflow if one is to save/reload the same file many times over several executions (the overflow problem could most probably arise realistically on 32bit OCaml, but I'd rather be cautious).
I did not add a test in the test suite, because cilly does not load/save binary files unfortunately. 😐