-
Notifications
You must be signed in to change notification settings - Fork 9
CRASM-2286- Refactor Playwright ECS task into its own bash script #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
55a4fee
to
c601701
Compare
…sion workflow to download from s3 latest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JCantu248 - thanks for maintaining this for so long. I get a good build and all test/checks are passing. I will merge on @aloftus23 , @cduhn17 and @jayjaybunce's approvals.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and am confident this will not affect P&E or XFD operations.
🗣 Description
This PR moves the ECS run-task logic from the regression.yml file to its own bash script for ease of development, testing and maintenance.
💭 Motivation and context
This is necessary to get the workflow up and running.
🧪 Testing
The bash script that runs the ecs run-task logic has been tested locally before being integrated into the regression workflow logic. That logic still needs to be tested, but the most difficult task has been tested locally.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.