Skip to content

CRASM-2286- Refactor Playwright ECS task into its own bash script #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from

Conversation

JCantu248
Copy link
Collaborator

@JCantu248 JCantu248 commented Apr 9, 2025

🗣 Description

This PR moves the ECS run-task logic from the regression.yml file to its own bash script for ease of development, testing and maintenance.

💭 Motivation and context

This is necessary to get the workflow up and running.

🧪 Testing

The bash script that runs the ecs run-task logic has been tested locally before being integrated into the regression workflow logic. That logic still needs to be tested, but the most difficult task has been tested locally.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@JCantu248 JCantu248 added bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code labels Apr 9, 2025
@JCantu248 JCantu248 self-assigned this Apr 9, 2025
@JCantu248 JCantu248 marked this pull request as ready for review April 9, 2025 14:45
@JCantu248 JCantu248 marked this pull request as draft April 11, 2025 14:39
@JCantu248 JCantu248 changed the title CRASM-2286- Fix incorrect escape characters in configuration strings in Regression Testing. CRASM-2286- Refactor Playwright ECS task into its own bash script Apr 11, 2025
@JCantu248 JCantu248 marked this pull request as ready for review April 11, 2025 15:56
@JCantu248 JCantu248 marked this pull request as draft April 11, 2025 16:03
Copy link
Collaborator

@schmelz21 schmelz21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JCantu248 - thanks for maintaining this for so long. I get a good build and all test/checks are passing. I will merge on @aloftus23 , @cduhn17 and @jayjaybunce's approvals.

Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and am confident this will not affect P&E or XFD operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality github-actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants