Skip to content

Create stats compare endpoint to compare two summaries CRASM-2584 #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

DJensen94
Copy link
Contributor

@DJensen94 DJensen94 commented Jun 10, 2025

🗣 Description

Create new endpoint that will compare summaries from two provided dates. The comparison will provide count deltas and percentage deltas as well as the full summary of the two dates

💭 Motivation and context

This endpoint will be used to show changes overtime for vs dashboard statistics. This will let stakeholders track changes to their attack surface over time.

🧪 Testing

Tested locally and via pytests

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

DJensen94 added 5 commits June 3, 2025 13:26
Create stats compare API endpoint.
Add comparison for risky services
Add back deleted imports
Remove none_counts from tests
@DJensen94 DJensen94 changed the title Create stats compare endpoint to compare two summaries Create stats compare endpoint to compare two summaries CRASM-2584 Jun 13, 2025
@DJensen94 DJensen94 marked this pull request as ready for review June 13, 2025 14:32
Copy link
Collaborator

@rapidray12 rapidray12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THe code is fine but we will need to work on accompanying documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants