Skip to content

CRASM-2716 Update the NoDataErrorDialog to show on Zero Value Results #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025

Conversation

nickviola
Copy link
Collaborator

@nickviola nickviola commented Jun 24, 2025

Closes: CRASM-2716

🗣 Description

Per leadership request, make the noDataErrorDialog show when the page loads, but there are zero values in the data.

💭 Motivation and context

Per leadership request, make the noDataErrorDialog show when the page loads, but there are zero values in the data.

🧪 Testing

On orgs with zero values in landing page, you should see the rendered results in the background as well as the error dialog.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@nickviola nickviola self-assigned this Jun 24, 2025
@nickviola nickviola changed the title Update the NoDataErrorDialog in VulnerabilityScan.tsx to show on 0 va… CRASM-2716 Update the NoDataErrorDialog to show on Zero Value Results Jun 25, 2025
@nickviola nickviola marked this pull request as ready for review June 25, 2025 16:20
@ameliav ameliav self-requested a review June 30, 2025 15:38
Copy link
Contributor

@ameliav ameliav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hawkishpolicy hawkishpolicy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@schmelz21 schmelz21 merged commit 4c1a4aa into develop Jul 2, 2025
15 of 16 checks passed
@schmelz21 schmelz21 deleted the NV-CRASM-2716-No-Data-Filter-Updates branch July 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants