Skip to content

Update Save Search body (CRASM-2604) #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2025

Conversation

hawkishpolicy
Copy link
Collaborator

@hawkishpolicy hawkishpolicy commented Jul 1, 2025

🗣 Description

  • a prior issue's(Elastic Search sort CRASM-2758) solution reset the casing of sort field and sort direction from snake case to camel case.
  • need to update the save search call to use the correct casing for sort field and sort direction.

💭 Motivation and context

  • Closes CRASM-2604

🧪 Testing

  • tested locally

📷 Screenshots (if appropriate)

Screen.Recording.2025-07-01.at.1.35.25.PM.mov

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

- a prior issue's(Elastic Search sort CRASM-2758) solution reset the casing of sort field and sort direction from snake case to camel case.
- need to update the save search call to use the correct casing for sort field and sort direction.
@hawkishpolicy hawkishpolicy self-assigned this Jul 1, 2025
@hawkishpolicy hawkishpolicy marked this pull request as ready for review July 1, 2025 17:37
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - review done in group

Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit f19543f into develop Jul 2, 2025
15 of 16 checks passed
@schmelz21 schmelz21 deleted the Unable-to-Save-Search-CRASM-2604 branch July 2, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants