Skip to content

Update import orgs with csv 2792 #985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025

Conversation

ameliav
Copy link
Contributor

@ameliav ameliav commented Jul 1, 2025

🗣 Description

  • Remove import organization via CSV capability
  • Remove add a new organization via UI form capability
  • Clean up code and styling involving the organizations/organization files
  • Fix org members bug
  • Update Tag Field on Edit Organization Pop-up

CRASM 2792 and 2793 and 2505

💭 Motivation and context

While locally the import organizations through a CSV and the UI form to create a new organization both worked, in Staging, these were throwing network errors.
Stephen advised that the solution would be to remove them until there is an ask for this functionality.
I've also used this PR to clean up the associated files or convert them to use MUI for a cleaner look and codebase.
There was also a bug not allowing you to go to the Org members tab which is now fixed.

🧪 Testing

A user should no longer see import organizations or create a new organization buttons

📷 Screenshots

image

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

@ameliav ameliav self-assigned this Jul 1, 2025
@ameliav ameliav marked this pull request as ready for review July 2, 2025 14:28
Copy link
Collaborator

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - review done in group

Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmelz21 schmelz21 merged commit 9acfd5e into develop Jul 2, 2025
15 of 16 checks passed
@schmelz21 schmelz21 deleted the update-import-orgs-with-csv-2792 branch July 2, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants