-
Notifications
You must be signed in to change notification settings - Fork 354
feat(clerk-js): Add bundleless ESM build #5964
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -23,7 +23,7 @@ | |||
"author": "Clerk", | |||
"main": "dist/clerk.js", | |||
"jsdelivr": "dist/clerk.browser.js", | |||
"module": "dist/clerk.mjs", | |||
"module": "dist/esm/index.mjs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be a breaking change in some cases ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would only break if someone was importing directly from dist/
. The only reason this is in a folder is because Rslib will, for some reason, run on all files in the input folder. So it would emit index.browser.js
which was confusing. Not a strong suggestion that we do it this way, just wanted to get it working for experimental purposes!
@clerk/agent-toolkit
@clerk/backend
@clerk/chrome-extension
@clerk/astro
@clerk/elements
@clerk/clerk-expo
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/clerk-react
@clerk/react-router
@clerk/tanstack-react-start
@clerk/testing
@clerk/remix
@clerk/themes
@clerk/types
@clerk/upgrade
@clerk/vue
@clerk/shared
commit: |
currently blocked by web-infra-dev/rslib#1007 and web-infra-dev/rslib#882 |
Description
(This PR is technically a draft; the pr.pkg.new workflow doesn't run on draft PRs.)
This experimental PR adds support for building a "bundleless" version of
clerk-js
, specifically the ESM build. More details to come if this experiment proves successful!Checklist
pnpm test
runs as expected.pnpm build
runs as expected.Type of change