Skip to content

feat(clerk-js,types,localizations): Payment history tab #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025

Conversation

aeliox
Copy link
Contributor

@aeliox aeliox commented Jun 5, 2025

Description

Adds Payment history tab to UserProfile and OrgProfile

Screenshot 2025-06-05 at 4 51 21 PM Screenshot 2025-06-05 at 4 48 26 PM

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: 9a433a4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 22 packages
Name Type
@clerk/localizations Patch
@clerk/clerk-js Patch
@clerk/types Patch
@clerk/clerk-react Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/agent-toolkit Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/expo-passkeys Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/nuxt Patch
@clerk/react-router Patch
@clerk/remix Patch
@clerk/shared Patch
@clerk/tanstack-react-start Patch
@clerk/testing Patch
@clerk/themes Patch
@clerk/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
clerk-js-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2025 6:56pm

Copy link

pkg-pr-new bot commented Jun 6, 2025

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@6075

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@6075

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@6075

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@6075

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@6075

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@6075

@clerk/elements

npm i https://pkg.pr.new/@clerk/elements@6075

@clerk/clerk-expo

npm i https://pkg.pr.new/@clerk/clerk-expo@6075

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@6075

@clerk/express

npm i https://pkg.pr.new/@clerk/express@6075

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@6075

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@6075

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@6075

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@6075

@clerk/clerk-react

npm i https://pkg.pr.new/@clerk/clerk-react@6075

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@6075

@clerk/remix

npm i https://pkg.pr.new/@clerk/remix@6075

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@6075

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@6075

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@6075

@clerk/themes

npm i https://pkg.pr.new/@clerk/themes@6075

@clerk/types

npm i https://pkg.pr.new/@clerk/types@6075

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@6075

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@6075

commit: 9a433a4

Copy link

@iagodahlem iagodahlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some tests and it looks all good! Just think we need to increase the limit on the payment history table a bit.

onPageChange={_ => {}}
itemCount={paymentAttempts?.total_count || 0}
pageCount={1}
itemsPerPage={10}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the C1 spams with a declined card, it might easily exceed 10 attempts. What do you think of increasing the value a bit here until we have pagination in place?

@aeliox aeliox merged commit 19e9e11 into main Jun 6, 2025
36 checks passed
@aeliox aeliox deleted the keiran/com-920-payment-history branch June 6, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants