Skip to content

Fix NODE_PATH for legacy projects #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
goto-bus-stop merged 8 commits into from
Apr 25, 2019
Merged

Fix NODE_PATH for legacy projects #235

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
860458a
Seems this doesn't matter anymore
wentout Apr 11, 2019
cfd5589
fix CI comma & occasionally replaced logger path
wentout Apr 11, 2019
ee226c3
onliner for makeInjectPath
wentout Apr 11, 2019
c4e9c49
Additional Fix after code-review.
wentout Apr 23, 2019
3ff566f
Finally got rid of broken parts.
wentout Apr 23, 2019
f467236
investigation checks issues
wentout Apr 23, 2019
e34ecd3
investigation checks issues 2
wentout Apr 23, 2019
51765a0
reverting changes for the test
wentout Apr 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,15 @@ class ClinicDoctor extends events.EventEmitter {
stdio.push('pipe')
}

let NODE_PATH = path.join(__dirname, 'injects')
// use NODE_PATH to work around issues with spaces in inject path
if (process.env.NODE_PATH) {
NODE_PATH += `${process.platform === 'win32' ? ';' : ':'}${process.env.NODE_PATH}`
}

const customEnv = {
// use NODE_PATH to work around issues with spaces in inject path
NODE_PATH: path.join(__dirname, 'injects'),
NODE_PATH,
NODE_OPTIONS: logArgs.join(' ') + (
process.env.NODE_OPTIONS ? ' ' + process.env.NODE_OPTIONS : ''
),
Expand Down