Allow '.' for typename in annotation comment#8
Closed
c9s wants to merge 2 commits intoclipperhouse:masterfrom
Closed
Allow '.' for typename in annotation comment#8c9s wants to merge 2 commits intoclipperhouse:masterfrom
c9s wants to merge 2 commits intoclipperhouse:masterfrom
Conversation
Summary: For types from other packages, we need to reference the typename with package name. e.g., "ast.Function"
Author
|
Use case code: // +gen symtable:"SymTable[ast.Function]"
type FunctionSymTable map[string]*ast.FunctionThis fixes the lexer, but we need to let the |
Author
|
I will submit the external type support in another PR. |
Author
|
Some updates
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
For types from other packages, we need to reference the typename with
package name. e.g., "ast.Function"
Related Issue: clipperhouse/gen#88